Linking LinkedIn Profile of Author in Blogs. #1751
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1751 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 29 29
Lines 548 548
Branches 158 158
=========================================
Hits 548 548 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Utkarsh-123github
requested changes
Aug 2, 2025
There was a problem hiding this comment.
Hi @cbum-dev , your code changes are working perfect. But there's a slight edge case which needs to be handled.
What if the social link provided by author is not a Linkedin/X URL ? for example see the screenshot.
I think for better code clarity and readability you can opt like this :
{author.link.includes("linkedin.com/in/")
? author.link
.replace(/https?:\/\/(www\.)?linkedin\.com\/in\//, '')
.replace(/\/$/, '')
: author.link}
I know the link will still be the same as it is in screenshot, but it's a good practice to check the edge case, so that there's no confusion for the new contributors.
github-project-automation
bot
moved this from Ready to review
to Changes requested
in PR - Triage Group
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Added both linkedin and twitter links in blog.
Issue Number:
Screenshots/videos:
If relevant, did you update the documentation?
Summary
Does this PR introduce a breaking change?
Checklist
Please ensure the following tasks are completed before submitting this pull request.